Skip to content

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Oct 30, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed copied items are pasted as shortcuts

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Oct 30, 2024
@yaira2 yaira2 requested a review from 0x5bfa October 31, 2024 13:54
if (packageView.Result.Contains(StandardDataFormats.StorageItems))
{
var items = await packageView.Result.GetStorageItemsAsync();
foreach (IStorageItem item in items)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hishitetsu would it be better to use Parallel?

@yaira2 yaira2 requested a review from 0x5bfa November 1, 2024 13:59
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code wise.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 1, 2024
@yaira2 yaira2 merged commit 4221568 into main Nov 1, 2024
8 checks passed
@yaira2 yaira2 deleted the ya/PasteAsShortcut branch November 1, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add support for pasting items as shortcut

3 participants